Use CreatePipeline instead of PipelineSpec for resources.Pipeline struct #2287
Conversation
andrewnester
requested review from
pietern,
shreyas-goenka and
denik
as code owners
|
Is it possible to use new API stubbing functionality (example: https://github.com/databricks/cli/blob/main/acceptance/workspace/jobs/create/test.toml#L6) to add a couple of acceptance tests:
|
There was a problem hiding this comment.
I agree it would be nice to drop dry_run and allow_duplicate_names from the schema, but we have examples of other resources with properties we don't intend to support so we can deal with that separately.
Just so that we can omit these properties later, could you make sure that they're not forwarded to TF as part of tfdyn? That way we can remove them later (when we also take a closer look at properties included for other resources) and not regress anything.
andrewnester
force-pushed
the
pipeline-spec-change
branch
from
340103d to
8245da8
Compare
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
@denik Once support for bundle deploy in acceptance test lands + TF change for |
| // will be exposed which is expected and test will need to be updated. | ||
| RunAs: &pipelines.RunAs{ | ||
| UserName: "foo@bar.com", | ||
| }, |
There was a problem hiding this comment.
So this PR is a no-op until the TF bump happens?
There was a problem hiding this comment.
Yes, it just uses a new struct and make sure we don't have schema changes for now
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Changes
CreatePipelineis a more complete structure (superset of PipelineSpec one) which enables support of additional fields such asrun_asandallow_duplicate_namesin DABs configuration. Note: these fields are subject to support in TF in order to correctly work.Tests
Existing tests pass + no fields are removed from JSON schema